Shourya's Blog

Submitting the patch This week I finally submitted a patch onto the List, though it wasn’t the only one I plan on sending to the List. In the last blog, I talked about the git log issue, which is fixed thankfully! There were some other problems which came up, but they are sorted now. The work on summary did reveal some issues in the test script t7401 as well—something which prompted me to create an entirely new test script. I also learnt about regular expressions, so that is another thing I will touch in this blog. The issue with t7401 The test t7401-submodule-summary.sh was written a long time ago, and the command git submodule add did not exist back then. Hence the submodules are added using git add in the test script. This leads to some unexpected behaviour when trying to run commands like git submodule init and git submodule deinit . I came across this issue while trying to add a test to verify the summary output of a deinitialised submodule. The test I

A quick week This week flew by very quick. It feels as if I wrote this blog a couple of days back. There is good progress as compared to last week and all issues listed in the previous blog are sorted! I did not realise this until I started writing this blog. Feels good. Now only one thing is left to sort out is one small issue which went unnoticed for so long but finally come to light after some investigation from Kaartic on his lxconf repository. I also need to add a couple of tests in t7401 which are related to the aforementioned issue(s). The issues Initially, there were two issues. But after rebasing my commits related to solutions of the other problems, one got solved but the other persisted. I will talk about both of them, starting with the solved one. Printing of some extra things in the summary of a deinitialised SM When I was trying to find the summary of a deinitialised SM, I should not have got any output since the SM is deinitialised. To my surpri

Addressing comments on my patch I spent this week addressing the suggestions made by Johannes which, were extremely detailed and long. I am done with most of the suggestions so I will highlight some important ones and what I learned from them. This week, I saw the ocean for I guess the first time in my life and it was a totally unique experience! Peaceful Seas Moving to the comments made by Johannes. Eliminate find_unique_abbrev() The shell version of summary calls git rev-parse twice for two jobs which are: Checking for a missing_src and a missing_dst i.e. , the missing source and destination committish. test $mod_src = 160000 && ! GIT_DIR="$name/.git" git rev-parse -q --verify $sha1_src^0 >/dev/null && missing_src=t test $mod_dst = 160000 && ! GIT_DIR="$name/.git" git rev-parse -q --verify $sha1_dst^0 >/dev/null && missing_dst=t Quoting my mentor Kaartic: The above code assigns missi

First evaluation complete! Last night, the results of the first evaluation came in and I was so happy to see a “Congratulations! You have passed the first evaluation” . It felt really good to see it! A huge thanks to Christian and Kaartic for believing in me :) First evaluation result This does call for a small celebration! After all this is the first time I have earned money from my work! A salary I guess ;) After quite some debugging, finally summary worked. The problem was a bit more skewed than it seemed and was far more serious than just for-status or prepare_submodule_summary() . I will explain what happened and how we waded through to make things first. The Problem As I said above, the problem was far more serious than just an option or a function. I will touch t7418 to make you familiar with what is going on. The first test in t7418 creates a Git repository in a directory called upstream and a submodule called… well submodule . The submodule is added